[0.76][Fix] Restore Metro log forwarding, change notice to signal future removal#46815
Merged
blakef merged 1 commit intofacebook:0.76-stablefrom Oct 7, 2024
Merged
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
Can you rebase off main to remove the annoying linter warnings? |
Member
Author
|
@blakef Oh, is latest |
Contributor
|
Oh, fair enough. Sorry got my signals crossed here. |
huntie
changed the title
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With React Native DevTools, we are removing legacy JavaScript log streaming via Metro (#43558). We had originally taken this step judicially, however to communicate this change better, we will leave this behaviour in place and show a notice for one release cycle.
Annotating as a fix because this impacts the rollout plan for a breaking change.
Learn more about this change in the Discussion FAQs.
Changelog:
[General][Changed] - Restore Metro log forwarding, change notice to signal future removal
Test Plan
Default
✅ Client logs are forwarded and streamed via Metro
✅ React Native DevTools notice is updated
With
server.forwardClientLogs = false(See Metro docs)
✅ No client logs, including no React Native DevTools notice
cc @byCedric